Skip to content

Check that intra-doc links are not broken - #17504

Merged
samueltardieu merged 1 commit into
rust-lang:masterfrom
samueltardieu:chores/check-doc-links
Sep 4, 2026
Merged

Check that intra-doc links are not broken#17504
samueltardieu merged 1 commit into
rust-lang:masterfrom
samueltardieu:chores/check-doc-links

Conversation

@samueltardieu

Copy link
Copy Markdown
Member

A broken link will make the Clippy subtree sync fail in the compiler repo.

changelog: none

@rustbot rustbot added the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 4, 2026
@rustbot

rustbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews.

In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 4, 2026
@samueltardieu

Copy link
Copy Markdown
Member Author

The issue corrected by this PR made the sync job fail.

@samueltardieu

Copy link
Copy Markdown
Member Author

r? @flip1995

@rustbot rustbot removed the S-waiting-on-community-reviews Status: This is awaiting for positive reviews from the community before a maintainer is assigned. label Aug 4, 2026

@ada4a ada4a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use cargo doc --workspace --no-deps instead?

View changes since this review

@samueltardieu

Copy link
Copy Markdown
Member Author

Any reason not to use cargo doc --workspace --no-deps instead?

We don't use a workspace, so it only builds the root, at least that what it did the last time I tried.

@flip1995

flip1995 commented Sep 3, 2026

Copy link
Copy Markdown
Member

We don't use a workspace, so it only builds the root, at least that what it did the last time I tried.

We should use one though. Maybe the next 3 year thing I tackle once the JOSH sync is done :D

@flip1995 flip1995 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flip1995

flip1995 commented Sep 3, 2026

Copy link
Copy Markdown
Member

@rustbot merge

@rustbot
rustbot added this pull request to the merge queue Sep 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 3, 2026
@samueltardieu
samueltardieu added this pull request to the merge queue Sep 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 3, 2026
@samueltardieu
samueltardieu added this pull request to the merge queue Sep 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 3, 2026
@samueltardieu

Copy link
Copy Markdown
Member Author

Fixed indentation problem which made the conclusion job invalid.

A broken link will make the Clippy subtree sync fail in the compiler
repo.
@samueltardieu
samueltardieu added this pull request to the merge queue Sep 4, 2026
Merged via the queue into rust-lang:master with commit 77ff5df Sep 4, 2026
12 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2026
@samueltardieu
samueltardieu deleted the chores/check-doc-links branch September 7, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants